add fields to support servers-side node size #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for allocation owner permissions on their tree (CADC-13241)
fix cavern unit tests and cleanup
pdowler
changed the title
andamian
approved these changes
Mar 4, 2024
| @@ -1010,9 +1011,26 @@ public void testPermissions() throws Exception { | |||
| 201, putAction.getResponseCode()); | |||
| Assert.assertNull("expected PUT throwable == null", putAction.getThrowable()); | |||
|
|
|||
| log.debug("Delete node " + childURL); | |||
| // test owner of root directory fails to read and delete due to a lack of explicit permission | |||
There was a problem hiding this comment.
I don't know how to test this after my changes. Depending on the server configuration it's either one or the other. To have both cases cover we need an int-tests directory in allocation and one outside.
complete cavern implementation
andamian
approved these changes
Mar 5, 2024
Co-authored-by: Adrian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fields no longer transient
no ContainerNode.delta